Open
Conversation
CodelineAtyab
requested changes
Aug 8, 2024
Owner
CodelineAtyab
left a comment
CodelineAtyab
left a comment
There was a problem hiding this comment.
Please check comments and make changes accordingly
| ENV SPRING_JPA_SHOW_SQL=true | ||
|
|
||
| # Run the Spring Boot application | ||
| ENTRYPOINT ["sh", "-c", "java -jar /app/rihal-0.0.1-SNAPSHOT.jar || (echo 'Application failed, sleeping indefinitely' && sleep infinity)"] |
Owner
There was a problem hiding this comment.
Usually we want a container to stop if Java application fails to run. In this case if the application doesn't run then the container would still be up which might cause confusion until someone looks at the logs.
Please share some thoughts about this ?
| environment: | ||
| SPRING_DATASOURCE_URL: jdbc:mysql://mysql:3307/usersystem?useSSL=false&serverTimezone=UTC&createDatabaseIfNotExist=true&allowPublicKeyRetrieval=true | ||
| SPRING_DATASOURCE_USERNAME: root | ||
| SPRING_DATASOURCE_PASSWORD: root |
Owner
There was a problem hiding this comment.
Its very important not to expose any password in code changes pushed to GitHub.
Using the .env file can help solve these issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solution involved creating a Dockerfile to containerize the Spring Boot application and a docker-compose.yml file to manage both the application and the MySQL database. The Dockerfile handles the build and run stages, while the Docker Compose file orchestrates the multi-container setup, ensuring the services are correctly configured and networked. This setup allows for easy deployment and management of the application in a containerized environment.